Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBU-199: enhancement proposal for dual-stack support with openstack #1365

Merged
merged 1 commit into from
Aug 1, 2023
Merged

OCPBU-199: enhancement proposal for dual-stack support with openstack #1365

merged 1 commit into from
Aug 1, 2023

Conversation

MaysaMacedo
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@MaysaMacedo
Copy link
Contributor Author

/cc @mandre

@openshift-ci openshift-ci bot requested a review from mandre March 20, 2023 16:56
@MaysaMacedo MaysaMacedo force-pushed the enhancement-dual-stack branch 2 times, most recently from abd824c to 9af1bb2 Compare March 21, 2023 18:46
@MaysaMacedo MaysaMacedo marked this pull request as ready for review March 22, 2023 08:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2023
@openshift-ci openshift-ci bot requested review from abhat and trozet March 22, 2023 08:46
@MaysaMacedo MaysaMacedo force-pushed the enhancement-dual-stack branch 2 times, most recently from 2063e64 to f330c63 Compare March 22, 2023 16:05
@MaysaMacedo MaysaMacedo force-pushed the enhancement-dual-stack branch from f330c63 to 5be5504 Compare March 23, 2023 09:51
mdbooth
mdbooth reviewed Mar 27, 2023
View reviewed changes
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
mdbooth
mdbooth reviewed Mar 30, 2023
View reviewed changes
enhancements/network/openstack-dual-stack.md Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Show resolved Hide resolved
@MaysaMacedo MaysaMacedo force-pushed the enhancement-dual-stack branch 2 times, most recently from e55d4ab to 618b613 Compare April 12, 2023 09:04
@MaysaMacedo MaysaMacedo mentioned this pull request Apr 25, 2023
Merged
dulek
dulek suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I have a few questions and suggestions inline.

enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
enhancements/network/openstack-dual-stack.md Outdated Show resolved Hide resolved
@MaysaMacedo
Copy link
Contributor Author

/cc @patrickdillon

would you mind to take a look on this enhancement? Thanks

@openshift-ci openshift-ci bot requested a review from patrickdillon June 28, 2023 17:12
@EmilienM
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
mandre
mandre reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MaysaMacedo
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2023
@MaysaMacedo
Copy link
Contributor Author

@dhellmann This enhancement looks ready. Can you have a look? Thanks in advance

@dhellmann
Copy link
Contributor

@dhellmann This enhancement looks ready. Can you have a look? Thanks in advance

@mandre is listed as the approver for this one. If all of the reviewers from all of the affected teams have accepted the proposal, Martin can take care of the approval step.

@mkowalski
Copy link
Contributor

/lgtm
On-Prem Networking Team is aware of this work and the enhancement itself looks sane. Other on-prem platforms (baremetal and vsphere) should not be affected. The change described here is not creating any divergence in how we do things already today for dual-stack

zshi-redhat
zshi-redhat reviewed Jul 27, 2023
View reviewed changes
enhancements/network/openstack-dual-stack.md

### Risks and Mitigations

The support for dual-stack in Kubelet's node-ip setting is a [feature in alpha state in Kubernetes v1.27](https://kubernetes.io/docs/concepts/services-networking/dual-stack/#configure-ipv4-ipv6-dual-stack) and requires a [fix to merge](https://github.com/kubernetes/kubernetes/pull/118662).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two risks specific to openshift on openstack? or do they apply to other dualstack-supported platforms?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix in subject is already merged and even backported to 1.27 so I wouldn't call it a risk anymore. The feature is already going to beta (kubernetes/enhancements#3975) so the risk that it's going to be dropped before GA is significantly lower.

Having said this, those both points were applying to any dual-stack platform, not only OpenStack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does dualstack support with openstack rely on the CloudDualStackNodeIPs feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@MaysaMacedo
Copy link
Contributor Author

@sadasu hello, following our discussions about the installer part of this enhancement, is there anything else to be discussed or it's ready from your perspective?

@MaysaMacedo MaysaMacedo mentioned this pull request Jul 27, 2023
Merged
@sadasu
Copy link
Contributor

sadasu commented Jul 31, 2023

I looked at this enhancement from the Installer perspective. LGTM from me expect for the one minor comment. @patrickdillon has been listed as the reviewer from the Installer team. So, I'll give me him a chance to take a look too.

@MaysaMacedo MaysaMacedo force-pushed the enhancement-dual-stack branch from e35d741 to 4f1f78f Compare July 31, 2023 22:54
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@sadasu
Copy link
Contributor

sadasu commented Jul 31, 2023

/lgtm
@MaysaMacedo thanks for addressing my comment. I looked at it from the Installer perspective. Note that @patrickdillon, who is the Installer team lead is listed the Installer reviewer.

@patrickdillon
Copy link
Contributor

patrickdillon commented Jul 31, 2023 via email

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@MaysaMacedo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks all for the reviews.
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit cafeb5c into openshift:master Aug 1, 2023
@MaysaMacedo MaysaMacedo deleted the enhancement-dual-stack branch August 9, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshi-redhat zshi-redhat zshi-redhat left review comments

@pierreprinetti pierreprinetti pierreprinetti left review comments

@sadasu sadasu sadasu left review comments

@mkowalski mkowalski mkowalski left review comments

@EmilienM EmilienM EmilienM left review comments

@mdbooth mdbooth mdbooth left review comments

@cybertron cybertron cybertron left review comments

@mandre mandre mandre left review comments

@dulek dulek dulek requested changes

@abhat abhat Awaiting requested review from abhat

@trozet trozet Awaiting requested review from trozet

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@mandre mandre

@EmilienM EmilienM

@mkowalski mkowalski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.